Support frozen bundle #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
approved these changes
Oct 31, 2025
sarahchen6
left a comment
sarahchen6
left a comment
There was a problem hiding this comment.
Looks reasonable! Should we leave a test for Ruby 1.8-2.5 and JRuby 9.2+ where I assume frozen bundles are not supported?
Member
Author
In a sense frozen bundle itself is supported on these versions, but injection cannot proceed due to other guardrails, so testing would be a bit... weird:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Frozen bundle is one of the underlying blocks of deployment mode, which is one of the major use cases in the wild.
What does this PR do?
How to test the change?
CI
Additional Notes:
Surprisingly frozen bundles appears to work OOTB thanks to using Bundler's own code.